Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 823993003: Push API: Remove AddAppHandlerIfNecessary to prevent DCHECK (Closed)

Created:
5 years, 11 months ago by johnme
Modified:
5 years, 11 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push API: Remove AddAppHandlerIfNecessary to prevent DCHECK Previously we would try to add the app handler twice for the first registration - once in AddAppHandlerIfNecessary called by RegisterFrom*, then again in IncreasePushRegistrationCount called by RegisterEnd. Adding the app handler a second time causes GCMDriver to DCHECK. It's ok to just add it in IncreasePushRegistrationCount (it was never actually necessary to have a GCMAppHandler to register). BUG=436453 Committed: https://crrev.com/d20f0147a03e5485ea95d25123dd8050fd2d0e2b Cr-Commit-Position: refs/heads/master@{#310523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M chrome/browser/services/gcm/push_messaging_service_impl.cc View 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
johnme
5 years, 11 months ago (2015-01-08 14:21:51 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 11 months ago (2015-01-08 16:08:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823993003/1
5 years, 11 months ago (2015-01-08 16:28:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 17:27:21 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 17:28:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d20f0147a03e5485ea95d25123dd8050fd2d0e2b
Cr-Commit-Position: refs/heads/master@{#310523}

Powered by Google App Engine
This is Rietveld 408576698