chrome/browser/prefs/chrome_pref_service_factory.h - Issue 90563003: Fix a race condition in preference metric reporting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/chrome_pref_service_factory.h

Issue 90563003: Fix a race condition in preference metric reporting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Also filter 'empty loads' as in new run or corrupted pref file scenarios. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/chrome_pref_service_factory.h

diff --git a/chrome/browser/prefs/chrome_pref_service_factory.h b/chrome/browser/prefs/chrome_pref_service_factory.h

index b1322b768e29e33a7bb6bd5defc7ac2298b30907..3456463fc6759cd08729b58969338a0f5a0c9843 100644

--- a/chrome/browser/prefs/chrome_pref_service_factory.h

+++ b/chrome/browser/prefs/chrome_pref_service_factory.h

@@ -22,6 +22,7 @@ class PrefRegistrySyncable;

}

class ManagedUserSettingsService;

+class PrefHashStore;

class PrefRegistry;

class PrefService;

class PrefServiceSyncable;

@@ -56,6 +57,7 @@ scoped_ptr<PrefServiceSyncable> CreateProfilePrefs(

base::SequencedTaskRunner* pref_io_task_runner,

policy::PolicyService* policy_service,

ManagedUserSettingsService* managed_user_settings,

+ scoped_ptr<PrefHashStore> pref_hash_store,

const scoped_refptr<PrefStore>& extension_prefs,

const scoped_refptr<user_prefs::PrefRegistrySyncable>& pref_registry,

bool async);