Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: chrome/browser/prefs/chrome_pref_service_factory.h

Issue 90563003: Fix a race condition in preference metric reporting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Also filter 'empty loads' as in new run or corrupted pref file scenarios. Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PREFS_CHROME_PREF_SERVICE_FACTORY_H_ 5 #ifndef CHROME_BROWSER_PREFS_CHROME_PREF_SERVICE_FACTORY_H_
6 #define CHROME_BROWSER_PREFS_CHROME_PREF_SERVICE_FACTORY_H_ 6 #define CHROME_BROWSER_PREFS_CHROME_PREF_SERVICE_FACTORY_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 10
11 namespace base { 11 namespace base {
12 class FilePath; 12 class FilePath;
13 class SequencedTaskRunner; 13 class SequencedTaskRunner;
14 } 14 }
15 15
16 namespace policy { 16 namespace policy {
17 class PolicyService; 17 class PolicyService;
18 } 18 }
19 19
20 namespace user_prefs { 20 namespace user_prefs {
21 class PrefRegistrySyncable; 21 class PrefRegistrySyncable;
22 } 22 }
23 23
24 class ManagedUserSettingsService; 24 class ManagedUserSettingsService;
25 class PrefHashStore;
25 class PrefRegistry; 26 class PrefRegistry;
26 class PrefService; 27 class PrefService;
27 class PrefServiceSyncable; 28 class PrefServiceSyncable;
28 class PrefStore; 29 class PrefStore;
29 30
30 namespace chrome_prefs { 31 namespace chrome_prefs {
31 32
32 // Factory methods that create and initialize a new instance of a 33 // Factory methods that create and initialize a new instance of a
33 // PrefService for Chrome with the applicable PrefStores. The 34 // PrefService for Chrome with the applicable PrefStores. The
34 // |pref_filename| points to the user preference file. This is the 35 // |pref_filename| points to the user preference file. This is the
(...skipping 14 matching lines...) Expand all
49 base::SequencedTaskRunner* pref_io_task_runner, 50 base::SequencedTaskRunner* pref_io_task_runner,
50 policy::PolicyService* policy_service, 51 policy::PolicyService* policy_service,
51 const scoped_refptr<PrefRegistry>& pref_registry, 52 const scoped_refptr<PrefRegistry>& pref_registry,
52 bool async); 53 bool async);
53 54
54 scoped_ptr<PrefServiceSyncable> CreateProfilePrefs( 55 scoped_ptr<PrefServiceSyncable> CreateProfilePrefs(
55 const base::FilePath& pref_filename, 56 const base::FilePath& pref_filename,
56 base::SequencedTaskRunner* pref_io_task_runner, 57 base::SequencedTaskRunner* pref_io_task_runner,
57 policy::PolicyService* policy_service, 58 policy::PolicyService* policy_service,
58 ManagedUserSettingsService* managed_user_settings, 59 ManagedUserSettingsService* managed_user_settings,
60 scoped_ptr<PrefHashStore> pref_hash_store,
59 const scoped_refptr<PrefStore>& extension_prefs, 61 const scoped_refptr<PrefStore>& extension_prefs,
60 const scoped_refptr<user_prefs::PrefRegistrySyncable>& pref_registry, 62 const scoped_refptr<user_prefs::PrefRegistrySyncable>& pref_registry,
61 bool async); 63 bool async);
62 64
63 } // namespace chrome_prefs 65 } // namespace chrome_prefs
64 66
65 #endif // CHROME_BROWSER_PREFS_CHROME_PREF_SERVICE_FACTORY_H_ 67 #endif // CHROME_BROWSER_PREFS_CHROME_PREF_SERVICE_FACTORY_H_
OLDNEW
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/prefs/chrome_pref_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698