Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: remoting/app_remoting_webapp_build.gypi

Issue 905553002: [Chromoting] Pass list of locale files into build-webapp in a single file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove --locales option from build-webapp.py Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/remoting_webapp.gypi » ('j') | remoting/remoting_webapp.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/app_remoting_webapp_build.gypi
diff --git a/remoting/app_remoting_webapp_build.gypi b/remoting/app_remoting_webapp_build.gypi
index d5da9ebd0d1a626083e846a3120b8254bcdf91b7..9e739f74f8b20222cf7aa6760a65f79cc5c358cf 100644
--- a/remoting/app_remoting_webapp_build.gypi
+++ b/remoting/app_remoting_webapp_build.gypi
@@ -71,6 +71,8 @@
'remoting_app_name': '>(_app_name)',
'remoting_app_description': '>(_app_description)',
+ 'ar_webapp_locales_listfile': '<(SHARED_INTERMEDIATE_DIR)/>(_target_name)_locales.txt',
+
'conditions': [
['ar_internal != 1', {
'ar_app_name': 'sample_app',
@@ -88,6 +90,23 @@
'actions': [
{
+ 'action_name': 'Build ">(ar_app_name)" locales listfile',
+ 'inputs': [
+ '<(remoting_localize_path)',
+ ],
+ 'outputs': [
+ '<(ar_webapp_locales_listfile)',
+ ],
+ 'action': [
+ 'python', '<(remoting_localize_path)',
+ '--locale_output',
+ '"<(webapp_locale_dir)/@{json_suffix}/messages.json"',
+ '--locales_listfile',
+ '<(ar_webapp_locales_listfile)',
+ '<@(remoting_locales)',
+ ],
+ },
+ {
'action_name': 'Build ">(ar_app_name)" application stub',
'inputs': [
'<(DEPTH)/remoting/webapp/build-webapp.py',
@@ -98,6 +117,7 @@
'<@(ar_generated_html_files)',
'<(ar_app_manifest_app)',
'<(DEPTH)/remoting/<(ar_app_manifest_common)',
+ '<(ar_webapp_locales_listfile)',
],
'outputs': [
'<(output_dir)',
@@ -113,8 +133,8 @@
'app_remoting', # Web app type
'<@(ar_webapp_files)',
'<@(ar_generated_html_files)',
- '--locales',
- '<@(remoting_webapp_locale_files)',
+ '--locales_listfile',
+ '<(ar_webapp_locales_listfile)',
'--jinja_paths',
'<(DEPTH)/remoting/webapp/app_remoting',
'<@(remoting_app_id)',
« no previous file with comments | « no previous file | remoting/remoting_webapp.gypi » ('j') | remoting/remoting_webapp.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698