Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: remoting/remoting_webapp.gypi

Issue 905553002: [Chromoting] Pass list of locale files into build-webapp in a single file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove --locales option from build-webapp.py Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/app_remoting_webapp_build.gypi ('k') | remoting/tools/build/remoting_localize.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/remoting_webapp.gypi
diff --git a/remoting/remoting_webapp.gypi b/remoting/remoting_webapp.gypi
index 0ad3fe6b953f2e627af7cdc4ab81d3982e1c42f6..2c767fda205d5a96c42824850c776b6b468db66f 100644
--- a/remoting/remoting_webapp.gypi
+++ b/remoting/remoting_webapp.gypi
@@ -13,6 +13,7 @@
'<(SHARED_INTERMEDIATE_DIR)/wcs_sandbox.html',
'<(SHARED_INTERMEDIATE_DIR)/background.html',
],
+ 'dr_webapp_locales_listfile': '<(SHARED_INTERMEDIATE_DIR)/>(_target_name)_locales.txt',
},
'dependencies': [
'remoting_resources',
@@ -47,12 +48,30 @@
],
'actions': [
{
+ 'action_name': 'Build Remoting locales listfile',
+ 'inputs': [
+ '<(remoting_localize_path)',
+ ],
+ 'outputs': [
+ '<(dr_webapp_locales_listfile)',
+ ],
+ 'action': [
+ 'python', '<(remoting_localize_path)',
Sergey Ulanov 2015/02/09 23:53:15 You don't really need this action. GYP allows to w
+ '--locale_output',
+ '"<(webapp_locale_dir)/@{json_suffix}/messages.json"',
+ '--locales_listfile',
+ '<(dr_webapp_locales_listfile)',
+ '<@(remoting_locales)',
+ ],
+ },
+ {
'action_name': 'Build Remoting WebApp',
'inputs': [
'webapp/build-webapp.py',
'webapp/crd/manifest.json.jinja2',
'<(chrome_version_path)',
'<(remoting_version_path)',
+ '<(dr_webapp_locales_listfile)',
'<@(generated_html_files)',
'<@(remoting_webapp_crd_files)',
'<@(remoting_webapp_locale_files)',
@@ -73,7 +92,8 @@
'<@(generated_html_files)',
'<@(remoting_webapp_crd_files)',
'<@(extra_files)',
- '--locales', '<@(remoting_webapp_locale_files)',
+ '--locales_listfile',
+ '<(dr_webapp_locales_listfile)',
],
},
],
« no previous file with comments | « remoting/app_remoting_webapp_build.gypi ('k') | remoting/tools/build/remoting_localize.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698