[Chromoting] Pass list of locale files into build-webapp in a single file.

[Chromoting] Pass list of locale files into build-webapp in a single file.

Previously each locale filename was passed separately on the command
line. This causes problems on Windows because of the 8K command line limit.

A follow-up cl will move the webapp filenames into separate files to reduce
the liklihood that we'll encounter this limit in the future.

BUG=

Committed: https://crrev.com/87430f2e66bd1e83d0a5c5ed2192b40717d5e0de
Cr-Commit-Position: refs/heads/master@{#314966}

[garykac, 2015-02-05 18:32:08]

garykac@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2015-02-05 19:26:20]

LGTM with nits.

https://codereview.chromium.org/905553002/diff/20001/remoting/tools/build/rem...
File remoting/tools/build/remoting_localize.py (right):

https://codereview.chromium.org/905553002/diff/20001/remoting/tools/build/rem...
remoting/tools/build/remoting_localize.py:769: '--print_to_filelist',
dest='print_to_filelist', type='string',
print_to_filelist sounds like it should be a boolean. Maybe locale_list_filename
would be a better name for the variable (the command-line can stay as it is if
you prefer).

https://codereview.chromium.org/905553002/diff/20001/remoting/webapp/build-we...
File remoting/webapp/build-webapp.py (right):

https://codereview.chromium.org/905553002/diff/20001/remoting/webapp/build-we...
remoting/webapp/build-webapp.py:377: '[--locales <locales...>] '
Do we still need to support --locales? If not then I think we should delete it
as a command-line option. If it's still needed for CRD, then we should migrate
that to use the same mechanism, then delete it (but that can be a follow-up CL).

https://codereview.chromium.org/905553002/diff/20001/remoting/webapp/build-we...
remoting/webapp/build-webapp.py:378: '[--locale_file <locale-file>] '
s/locale/locales/g (it contains a list of all locales, right?)

[garykac, 2015-02-06 01:41:49]

New patchsets have been uploaded after l-g-t-m from jamiewalch@chromium.org

[garykac, 2015-02-06 02:13:23]

The CQ bit was checked by garykac@chromium.org

[garykac, 2015-02-06 02:13:35]

https://codereview.chromium.org/905553002/diff/20001/remoting/tools/build/rem...
File remoting/tools/build/remoting_localize.py (right):

https://codereview.chromium.org/905553002/diff/20001/remoting/tools/build/rem...
remoting/tools/build/remoting_localize.py:769: '--print_to_filelist',
dest='print_to_filelist', type='string',
On 2015/02/05 19:26:20, Jamie wrote:
> print_to_filelist sounds like it should be a boolean. Maybe
locale_list_filename
> would be a better name for the variable (the command-line can stay as it is if
> you prefer).

Done.

https://codereview.chromium.org/905553002/diff/20001/remoting/webapp/build-we...
File remoting/webapp/build-webapp.py (right):

https://codereview.chromium.org/905553002/diff/20001/remoting/webapp/build-we...
remoting/webapp/build-webapp.py:377: '[--locales <locales...>] '
On 2015/02/05 19:26:20, Jamie wrote:
> Do we still need to support --locales? If not then I think we should delete it
> as a command-line option. If it's still needed for CRD, then we should migrate
> that to use the same mechanism, then delete it (but that can be a follow-up
CL).

Done.

https://codereview.chromium.org/905553002/diff/20001/remoting/webapp/build-we...
remoting/webapp/build-webapp.py:378: '[--locale_file <locale-file>] '
On 2015/02/05 19:26:20, Jamie wrote:
> s/locale/locales/g (it contains a list of all locales, right?)

Done.

[commit-bot: I haz the power, 2015-02-06 02:14:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/905553002/40001

[commit-bot: I haz the power, 2015-02-06 03:45:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-06 03:46:52]

Patchset 3 (id:??) landed as
https://crrev.com/87430f2e66bd1e83d0a5c5ed2192b40717d5e0de
Cr-Commit-Position: refs/heads/master@{#314966}

[Sergey Ulanov, 2015-02-09 23:53:15]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2015-02-09 23:53:15]

https://codereview.chromium.org/905553002/diff/40001/remoting/remoting_webapp...
File remoting/remoting_webapp.gypi (right):

https://codereview.chromium.org/905553002/diff/40001/remoting/remoting_webapp...
remoting/remoting_webapp.gypi:59: 'python', '<(remoting_localize_path)',
You don't really need this action. GYP allows to write list into a file using
this syntax: "<|(file_name ^(list_to_write_to_the_file))" . E.g. see
untrusted.gypi for example:
https://code.google.com/p/chromium/codesearch#chromium/src/native_client/buil...