Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 905293002: Remove dependency on v8.h from TurboFan. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove dependency on v8.h from TurboFan. R=bmeurer@chromium.org TEST=presubmit Committed: https://crrev.com/215e6bcb0033dc1f50948d862c8d3dbce11cf96c Cr-Commit-Position: refs/heads/master@{#26525}

Patch Set 1 #

Patch Set 2 : Fix ARM and ARM64 builds. #

Patch Set 3 : Add DEPS file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -45 lines) Patch
A + src/compiler/DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/all-nodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/arm/linkage-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/ast-loop-assignment-analyzer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/basic-block-instrumentor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/control-builders.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/control-equivalence.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/diamond.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/frame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/graph-builder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-context-specialization.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/mips/linkage-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/mips64/linkage-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/pipeline.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/ppc/linkage-ppc.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/register-allocator-verifier.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/register-configuration.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/register-configuration.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/scheduler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/typer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/verifier.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/zone-pool.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-09 12:06:10 UTC) #1
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-09 12:06:54 UTC) #2
Benedikt Meurer
Still LGTM
5 years, 10 months ago (2015-02-09 12:21:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905293002/40001
5 years, 10 months ago (2015-02-09 12:52:59 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 13:13:21 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 13:13:37 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/215e6bcb0033dc1f50948d862c8d3dbce11cf96c
Cr-Commit-Position: refs/heads/master@{#26525}

Powered by Google App Engine
This is Rietveld 408576698