Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 905283002: Fix the MachineSignature* parameters change for turbofan unsupported platform. (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix the MachineSignature* parameters change for turbofan unsupported platform. this issue is introduced by 30787d4e564efe7f85182bd5b1b99e9f40e265ca. (https://codereview.chromium.org/874693006). original commit message: Const-corrected some MachineSignature* parameters. Recipe: Add "const" to RawMachineAssembler constructor, fix breakage. BUG= Committed: https://crrev.com/68db76e1b6b8722ba01a90196f18db86d677c279 Cr-Commit-Position: refs/heads/master@{#26538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-09 11:21:57 UTC) #3
Weiliang
lgtm lgtm from me, but still require lgtm from v8 team.
5 years, 10 months ago (2015-02-10 07:32:34 UTC) #5
Sven Panne
lgtm
5 years, 10 months ago (2015-02-10 08:32:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905283002/1
5 years, 10 months ago (2015-02-10 08:33:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-10 08:56:05 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 08:56:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68db76e1b6b8722ba01a90196f18db86d677c279
Cr-Commit-Position: refs/heads/master@{#26538}

Powered by Google App Engine
This is Rietveld 408576698