Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 874693006: Const-corrected some MachineSignature* parameters. (Closed)

Created:
5 years, 10 months ago by Sven Panne
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Const-corrected some MachineSignature* parameters. Recipe: Add "const" to RawMachineAssembler constructor, fix breakage. Committed: https://crrev.com/30787d4e564efe7f85182bd5b1b99e9f40e265ca Cr-Commit-Position: refs/heads/master@{#26485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M src/compiler/arm/linkage-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/mips/linkage-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/linkage-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ppc/linkage-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 10 months ago (2015-02-06 11:57:03 UTC) #2
dcarney
lgtm
5 years, 10 months ago (2015-02-06 12:03:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/874693006/1
5 years, 10 months ago (2015-02-06 12:05:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 12:18:51 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 12:18:58 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/30787d4e564efe7f85182bd5b1b99e9f40e265ca
Cr-Commit-Position: refs/heads/master@{#26485}

Powered by Google App Engine
This is Rietveld 408576698