Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 904783002: Subzero: Convert a few getName() methods to return a const string ref. (Closed)

Created:
5 years, 10 months ago by jvoung (off chromium)
Modified:
5 years, 10 months ago
Reviewers:
Karl, Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert a few getName() methods to return a const string ref. Followup to a previous code review. Saves 2KB from the minimal build =) BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c9ec5793338dd62d84246f3143fd7ffc70cbc89b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/IceELFObjectWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceELFSection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceOperand.h View 1 chunk +1 line, -1 line 0 comments Download
M src/PNaClTranslator.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 10 months ago (2015-02-06 00:01:23 UTC) #2
Jim Stichnoth
lgtm, thanks!
5 years, 10 months ago (2015-02-06 00:28:04 UTC) #3
jvoung (off chromium)
Committed patchset #1 (id:1) manually as c9ec5793338dd62d84246f3143fd7ffc70cbc89b (presubmit successful).
5 years, 10 months ago (2015-02-06 01:31:40 UTC) #4
native-client-reviews_googlegroups.com
5 years, 10 months ago (2015-02-06 01:48:34 UTC) #5
Message was sent while issue was closed.
+page hat on: why have strings at all in the minimal build?

On Thu, Feb 5, 2015 at 5:31 PM, <jvoung@chromium.org> wrote:

> Committed patchset #1 (id:1) manually as
> c9ec5793338dd62d84246f3143fd7ffc70cbc89b (presubmit successful).
>
>
> https://codereview.chromium.org/904783002/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to native-client-reviews+unsubscribe@googlegroups.com.
> To post to this group, send email to native-client-reviews@
> googlegroups.com.
> Visit this group at http://groups.google.com/group/native-client-reviews.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

Powered by Google App Engine
This is Rietveld 408576698