Subzero: Convert a few getName() methods to return a const string ref.

src/PNaClTranslator.cpp

 //===- subzero/src/PNaClTranslator.cpp - ICE from bitcode -----------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the PNaCl bitcode file to Ice, to machine code
@@ skipping 276 matching lines @@
     bool IsUndefined = false;
     if (ID < FcnIDSize) {
       Decl = FunctionDeclarationList[ID];
       const auto Func = llvm::cast<Ice::FunctionDeclaration>(Decl);
       IsUndefined = Func->isProto();
     } else if ((ID - FcnIDSize) < VariableDeclarations.size()) {
       Decl = VariableDeclarations[ID - FcnIDSize];
       const auto Var = llvm::cast<Ice::VariableDeclaration>(Decl);
       IsUndefined = !Var->hasInitializer();
     }
-    std::string Name;
+    Ice::IceString Name;
     bool SuppressMangling;
     if (Decl) {
       Name = Decl->getName();
       SuppressMangling = Decl->getSuppressMangling();
     } else {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Reference to global not defined: " << ID;
       BlockError(StrBuf.str());
       // TODO(kschimpf) Remove error recovery once implementation complete.
@@ skipping 1193 matching lines @@
     if (C == nullptr)
       return VectorIndexNotConstant;
     if (static_cast<size_t>(C->getValue()) >= typeNumElements(VecType))
       return VectorIndexNotInRange;
     if (Index->getType() != Ice::IceType_i32)
       return VectorIndexNotI32;
     return VectorIndexValid;
   }
 
   // Returns true if the Str begins with Prefix.
-  bool isStringPrefix(Ice::IceString &Str, Ice::IceString &Prefix) {
+  bool isStringPrefix(const Ice::IceString &Str, const Ice::IceString &Prefix) {
     const size_t PrefixSize = Prefix.size();
     if (Str.size() < PrefixSize)
       return false;
     for (size_t i = 0; i < PrefixSize; ++i) {
       if (Str[i] != Prefix[i])
         return false;
     }
     return true;
   }
 
@@ skipping 917 matching lines @@
     Ice::Operand *Callee = getOperand(CalleeIndex);
     Ice::Type ReturnType = Ice::IceType_void;
     const Ice::Intrinsics::FullIntrinsicInfo *IntrinsicInfo = nullptr;
     if (Record.GetCode() == naclbitc::FUNC_CODE_INST_CALL) {
       Ice::FunctionDeclaration *Fcn = Context->getFunctionByID(CalleeIndex);
       const Ice::FuncSigType &Signature = Fcn->getSignature();
       ReturnType = Signature.getReturnType();
 
       // Check if this direct call is to an Intrinsic (starts with "llvm.")
       static Ice::IceString LLVMPrefix("llvm.");
-      Ice::IceString Name = Fcn->getName();
+      const Ice::IceString &Name = Fcn->getName();
       if (isStringPrefix(Name, LLVMPrefix)) {
         Ice::IceString Suffix = Name.substr(LLVMPrefix.size());
         IntrinsicInfo =
             getTranslator().getContext()->getIntrinsicsInfo().find(Suffix);
         if (!IntrinsicInfo) {
           std::string Buffer;
           raw_string_ostream StrBuf(Buffer);
           StrBuf << "Invalid PNaCl intrinsic call to " << Name;
           Error(StrBuf.str());
           appendErrorInstruction(ReturnType);
@@ skipping 561 matching lines @@
 
   if (TopLevelBlocks != 1) {
     errs() << IRFilename
            << ": Contains more than one module. Found: " << TopLevelBlocks
            << "\n";
     ErrorStatus.assign(EC_Bitcode);
   }
 }
 
 } // end of namespace Ice