Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 904673004: Fixed test by changing the way a subframe was added. (Closed)

Created:
5 years, 10 months ago by carlosk
Modified:
5 years, 10 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, clamy, Fabrice (no longer in Chrome), nasko, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed test by changing the way a subframe was added. Test NavigatorTestWithBrowserSideNavigation.BeginNavigation was broken due to the way the subframe used was added to the tree. By directly calling FrameTree::AddFrame the proper observer notifications were not being executed and triggered a sanity check. It was replaced with the already test-tailored TestRenderFrameHost::AppendChild. BUG=455484 Committed: https://crrev.com/fdf32b55ff6e5036c19f0f6761c05c6453c63a4d Cr-Commit-Position: refs/heads/master@{#315063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/frame_host/navigator_impl_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
carlosk
creis: PTAL.
5 years, 10 months ago (2015-02-06 15:05:32 UTC) #2
Charlie Reis
Thanks! LGTM. Looks like Nasko disabled this test in https://codereview.chromium.org/905463004, so I'll revert that as ...
5 years, 10 months ago (2015-02-06 17:53:53 UTC) #3
Charlie Reis
[+nasko,site-isolation-reviews for test fix FYI]
5 years, 10 months ago (2015-02-06 17:54:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904673004/1
5 years, 10 months ago (2015-02-06 17:55:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 17:58:37 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 17:59:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdf32b55ff6e5036c19f0f6761c05c6453c63a4d
Cr-Commit-Position: refs/heads/master@{#315063}

Powered by Google App Engine
This is Rietveld 408576698