Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 905463004: Disable NavigatorTestWithBrowserSideNavigation.BeginNavigation (Closed)

Created:
5 years, 10 months ago by nasko
Modified:
5 years, 10 months ago
Reviewers:
jam, alexmos
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable NavigatorTestWithBrowserSideNavigation.BeginNavigation This test fails within the WebContentsObserverSanityChecker, since no IPC for RenderFrameCreated is sent. Disable while we find a good way to make the sanity checker play nicely within the unit test framework running in --site-per-process BUG=417518 Committed: https://crrev.com/33e0ed259a19bc6c918fa11fcacffdf709440447 Cr-Commit-Position: refs/heads/master@{#314960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/buildbot/chromium.fyi.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
nasko
Hey Alex, Can you review this CL for me? It disables the unit test that ...
5 years, 10 months ago (2015-02-05 23:17:48 UTC) #2
alexmos
LGTM
5 years, 10 months ago (2015-02-05 23:19:08 UTC) #3
nasko
Hey John, Can you do an OWNERS review for this CL? Thanks in advance! Nasko
5 years, 10 months ago (2015-02-06 00:36:57 UTC) #5
jam
lgtm
5 years, 10 months ago (2015-02-06 01:29:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/905463004/1
5 years, 10 months ago (2015-02-06 01:31:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 03:40:09 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/33e0ed259a19bc6c918fa11fcacffdf709440447 Cr-Commit-Position: refs/heads/master@{#314960}
5 years, 10 months ago (2015-02-06 03:41:32 UTC) #10
Charlie Reis
5 years, 10 months ago (2015-02-06 18:02:53 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/870653006/ by creis@chromium.org.

The reason for reverting is: Test fixed in
https://codereview.chromium.org/904673004/, https://crrev.com/315063..

Powered by Google App Engine
This is Rietveld 408576698