pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart - Issue 904603004: rename completion constants and cleanup comment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

Issue 904603004: rename completion constants and cleanup comment (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/local_computer.dart ('k') | pkg/analysis_server/test/domain_completion_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

index ae607b28a41357c25f21d679f2626e28a5b9c9a6..ba6c396fcaf221b48ea77ed1ecfe5fef0f8c6dbc 100644

--- a/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

+++ b/pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart

@@ -23,7 +23,7 @@ const String DYNAMIC = 'dynamic';

CompletionSuggestion createSuggestion(Element element,

{CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,

- int relevance: COMPLETION_RELEVANCE_DEFAULT}) {

+ int relevance: DART_RELEVANCE_DEFAULT}) {

String nameForType(DartType type) {

if (type == null) {

@@ -58,7 +58,7 @@ CompletionSuggestion createSuggestion(Element element,

bool isDeprecated = element.isDeprecated;

CompletionSuggestion suggestion = new CompletionSuggestion(

kind,

- isDeprecated ? COMPLETION_RELEVANCE_LOW : relevance,

+ isDeprecated ? DART_RELEVANCE_LOW : relevance,

completion,

completion.length,

@@ -186,7 +186,7 @@ abstract class ElementSuggestionBuilder {

/**

* Add a suggestion based upon the given element.

- void addSuggestion(Element element, {int relevance: COMPLETION_RELEVANCE_DEFAULT}) {

+ void addSuggestion(Element element, {int relevance: DART_RELEVANCE_DEFAULT}) {

if (element.isPrivate) {

LibraryElement elementLibrary = element.library;

LibraryElement unitLibrary = request.unit.element.library;