Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: pkg/analysis_server/lib/src/services/completion/local_computer.dart

Issue 904603004: rename completion constants and cleanup comment (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/local_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/local_computer.dart b/pkg/analysis_server/lib/src/services/completion/local_computer.dart
index 040ead5fd49a4d50abf7a8d17584e8ffad093122..4a7584f231cdb780f771b613d2a57ada415602c0 100644
--- a/pkg/analysis_server/lib/src/services/completion/local_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/local_computer.dart
@@ -160,7 +160,7 @@ class _LabelVisitor extends LocalDeclarationVisitor {
if (completion != null && completion.length > 0 && completion != '_') {
CompletionSuggestion suggestion = new CompletionSuggestion(
CompletionSuggestionKind.IDENTIFIER,
- COMPLETION_RELEVANCE_DEFAULT,
+ DART_RELEVANCE_DEFAULT,
completion,
completion.length,
0,
@@ -211,7 +211,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {
declaration.name,
NO_RETURN_TYPE,
isDeprecated,
- COMPLETION_RELEVANCE_DEFAULT);
+ DART_RELEVANCE_DEFAULT);
if (suggestion != null) {
suggestion.element = _createElement(
protocol.ElementKind.CLASS,
@@ -229,7 +229,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {
declaration.name,
NO_RETURN_TYPE,
isDeprecated,
- COMPLETION_RELEVANCE_DEFAULT);
+ DART_RELEVANCE_DEFAULT);
if (suggestion != null) {
suggestion.element = _createElement(
protocol.ElementKind.CLASS_TYPE_ALIAS,
@@ -270,7 +270,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {
TypeName returnType = declaration.returnType;
bool isDeprecated = _isDeprecated(declaration);
protocol.ElementKind kind;
- int defaultRelevance = COMPLETION_RELEVANCE_DEFAULT;
+ int defaultRelevance = DART_RELEVANCE_DEFAULT;
if (declaration.isGetter) {
kind = protocol.ElementKind.GETTER;
defaultRelevance = DART_RELEVANCE_LOCAL_ACCESSOR;
@@ -317,7 +317,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {
declaration.name,
returnType,
isDeprecated,
- COMPLETION_RELEVANCE_DEFAULT);
+ DART_RELEVANCE_DEFAULT);
if (suggestion != null) {
// TODO (danrubel) determine parameters and return type
suggestion.element = _createElement(
@@ -355,7 +355,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {
protocol.ElementKind kind;
String parameters;
TypeName returnType = declaration.returnType;
- int defaultRelevance = COMPLETION_RELEVANCE_DEFAULT;
+ int defaultRelevance = DART_RELEVANCE_DEFAULT;
if (declaration.isGetter) {
kind = protocol.ElementKind.GETTER;
parameters = null;
@@ -472,7 +472,7 @@ class _LocalVisitor extends LocalDeclarationVisitor {
if (completion != null && completion.length > 0 && completion != '_') {
CompletionSuggestion suggestion = new CompletionSuggestion(
CompletionSuggestionKind.INVOCATION,
- isDeprecated ? COMPLETION_RELEVANCE_LOW : defaultRelevance,
+ isDeprecated ? DART_RELEVANCE_LOW : defaultRelevance,
completion,
completion.length,
0,

Powered by Google App Engine
This is Rietveld 408576698