Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 904493002: handler: Write crash reports to a crash report database (Closed)

Created:
5 years, 10 months ago by Mark Mentovai
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 : Create CrashReportExceptionHandler #

Patch Set 2 : Use CrashReportDatabase #

Patch Set 3 : Use FileHandleFileWriter and CrashReportDatabase::ErrorWritingCrashReport() #

Patch Set 4 : Rename FileHandleFileWriter to WeakFileHandleFileWriter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -32 lines) Patch
M handler/handler.gyp View 1 2 chunks +5 lines, -0 lines 0 comments Download
A handler/mac/crash_report_exception_handler.h View 1 chunk +65 lines, -0 lines 0 comments Download
A handler/mac/crash_report_exception_handler.cc View 1 2 3 1 chunk +138 lines, -0 lines 0 comments Download
M handler/mac/exception_handler_server.h View 2 chunks +13 lines, -8 lines 0 comments Download
M handler/mac/exception_handler_server.cc View 5 chunks +22 lines, -23 lines 0 comments Download
M handler/mac/main.cc View 7 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Mark Mentovai
This depends on https://codereview.chromium.org/904533002/ and https://codereview.chromium.org/871193010/.
5 years, 10 months ago (2015-02-04 21:14:15 UTC) #3
Robert Sesek
LGTM!!
5 years, 10 months ago (2015-02-04 23:09:28 UTC) #4
Mark Mentovai
5 years, 10 months ago (2015-02-04 23:32:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:80001) manually as
409742cd40bcd163a40146bc69fe220d79f70ef3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698