Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: handler/mac/exception_handler_server.h

Issue 904493002: handler: Write crash reports to a crash report database (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Rename FileHandleFileWriter to WeakFileHandleFileWriter Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « handler/mac/crash_report_exception_handler.cc ('k') | handler/mac/exception_handler_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: handler/mac/exception_handler_server.h
diff --git a/handler/mac/exception_handler_server.h b/handler/mac/exception_handler_server.h
index a0a5764a82cb31391247803523c76b8ec38f85ea..37c61a0f48652b7faa0a0b2d445b614bf1bc43a8 100644
--- a/handler/mac/exception_handler_server.h
+++ b/handler/mac/exception_handler_server.h
@@ -20,6 +20,7 @@
#include <mach/mach.h>
#include "base/mac/scoped_mach_port.h"
+#include "util/mach/exc_server_variants.h"
namespace crashpad {
@@ -32,20 +33,24 @@ class ExceptionHandlerServer {
//! \brief Runs the exception-handling server.
//!
- //! This method monitors \a receive_port_ for exception messages and
- //! no-senders notifications. It continues running until it has no more
- //! clients, indicated by the receipt of a no-senders notification. It is
- //! important to assure that a send right has been transferred to a client
- //! (or queued by `mach_msg()` to be sent to a client) prior to calling this
- //! method, or it will detect that it is sender-less and return immediately.
+ //! \param[in] exception_interface An object to send exception messages to.
+ //!
+ //! This method monitors receive_port() for exception messages and no-senders
+ //! notifications. It continues running until it has no more clients,
+ //! indicated by the receipt of a no-senders notification. It is important to
+ //! assure that a send right has been transferred to a client (or queued by
+ //! `mach_msg()` to be sent to a client) prior to calling this method, or it
+ //! will detect that it is sender-less and return immediately.
+ //!
+ //! All exception messages will be passed to \a exception_interface.
//!
//! This method must only be called once on an ExceptionHandlerServer object.
//!
//! If an unexpected condition that prevents this method from functioning is
//! encountered, it will log a message and terminate execution. Receipt of an
- //! invalid message on \a receive_port_ will cause a message to be logged, but
+ //! invalid message on receive_port() will cause a message to be logged, but
//! this method will continue running normally.
- void Run();
+ void Run(UniversalMachExcServer::Interface* exception_interface);
//! \brief Returns the receive right that will be monitored for exception
//! messages.
« no previous file with comments | « handler/mac/crash_report_exception_handler.cc ('k') | handler/mac/exception_handler_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698