Issue 904253002: Support more than just png files for diff images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 904253002: Support more than just png files for diff images. (Closed)

Created:
5 years, 10 months ago by esprehn

Modified:
5 years, 10 months ago

Reviewers:
jrobbins, ojan

CC:
chromium-reviews, rmistry+cc_chromium.org

Base URL:
https://chromium.googlesource.com/infra/infra.git@master

Target Ref:
refs/heads/master

Project:
infra

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -2 lines)			Patch
	M	appengine/chromium_rietveld/new_static/diff/diff_parser.js	View		2 chunks	+19 lines, -2 lines	0 comments	Download
	M	appengine/chromium_rietveld/new_static/diff/diff_parser_tests.js	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904253002/1

5 years, 10 months ago (2015-02-08 05:47:16 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-08 05:49:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/061b744a654f0a80c8d6ba2792356...