Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Unified Diff: appengine/chromium_rietveld/new_static/diff/diff_parser.js

Issue 904253002: Support more than just png files for diff images. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/chromium_rietveld/new_static/diff/diff_parser_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/chromium_rietveld/new_static/diff/diff_parser.js
diff --git a/appengine/chromium_rietveld/new_static/diff/diff_parser.js b/appengine/chromium_rietveld/new_static/diff/diff_parser.js
index 3f28c1577a84da6b912055569dc0c7e65d903f78..54e7b6f12f5d7daa2a8fc06457f9b763fb10ff1c 100644
--- a/appengine/chromium_rietveld/new_static/diff/diff_parser.js
+++ b/appengine/chromium_rietveld/new_static/diff/diff_parser.js
@@ -13,12 +13,29 @@ function DiffParser(text)
DiffParser.HEADER_BEGIN = "Index: ";
DiffParser.TEXT_HEADER_END = "+++ ";
DiffParser.BINARY_HEADER_END = "Binary files ";
-DiffParser.PNG_SUFFIX = ".png";
DiffParser.COPY_FROM_PREFIX = "copy from ";
DiffParser.COPY_TO_PREFIX = "copy to ";
DiffParser.RENAME_FROM_PREFIX = "rename from ";
DiffParser.RENAME_TO_PREFIX = "rename to ";
DiffParser.HEADER_PATTERN = /^@@ \-(\d+),[^+]+\+(\d+)(,\d+)? @@ ?(.*)/;
+DiffParser.IMAGE_EXTENSIONS = {
+ "png": true,
+ "jpeg": true,
+ "jpg": true,
+ "webp": true,
+ "bmp": true,
+ "gif": true,
+};
+
+DiffParser.isImageFile = function(name)
+{
+ var index = name.lastIndexOf(".");
+ // Dot files are not images.
+ if (index <= 0)
+ return false;
+ var extension = name.from(index + 1);
+ return DiffParser.IMAGE_EXTENSIONS[extension];
+};
DiffParser.prototype.peekLine = function()
{
@@ -177,7 +194,7 @@ DiffParser.prototype.parse = function()
var groups = this.parseFile();
result.push({
name: name,
- isImage: name.endsWith(DiffParser.PNG_SUFFIX),
+ isImage: DiffParser.isImageFile(name),
from: header.from,
to: header.to,
external: header.from && groups.length == 1,
« no previous file with comments | « no previous file | appengine/chromium_rietveld/new_static/diff/diff_parser_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698