Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 904233002: Revert of Temporary commit to evaluate perf impact of prototype CPU profiler (Closed)

Created:
5 years, 10 months ago by Mike Wittman
Modified:
5 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Temporary commit to evaluate perf impact of prototype CPU profiler (patchset #10 id:170001 of https://codereview.chromium.org/888923004/) Reason for revert: Reverting temporary commit. Original issue's description: > Temporary commit to evaluate perf impact of prototype CPU profiler > > Design doc: https://docs.google.com/document/d/1Bv-I1yM9AjgY3t27ixdyWHCAW9IpVx02YQ-nSbIqccc > > BUG= > > Committed: https://crrev.com/47c6093645b62fbc9f68cf50375fc0626e32516c > Cr-Commit-Position: refs/heads/master@{#315196} TBR=cpu@chromium.org,wfh@chromium.org,vadimt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/21a43cf747cd3388e03b25d72f29731671df95f5 Cr-Commit-Position: refs/heads/master@{#315217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -484 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
D base/profiler/cpu_profiler.h View 1 chunk +0 lines, -78 lines 0 comments Download
D base/profiler/cpu_profiler.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D base/profiler/cpu_profiler_posix.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D base/profiler/cpu_profiler_win.cc View 1 chunk +0 lines, -196 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike Wittman
Created Revert of Temporary commit to evaluate perf impact of prototype CPU profiler
5 years, 10 months ago (2015-02-07 22:05:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/904233002/1
5 years, 10 months ago (2015-02-07 22:05:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 22:05:58 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 22:06:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21a43cf747cd3388e03b25d72f29731671df95f5
Cr-Commit-Position: refs/heads/master@{#315217}

Powered by Google App Engine
This is Rietveld 408576698