Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: components/crash/app/crash_reporter_client.cc

Issue 904213002: [components/crash] Add crash client method to enable microdumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/app/crash_reporter_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/app/crash_reporter_client.cc
diff --git a/components/crash/app/crash_reporter_client.cc b/components/crash/app/crash_reporter_client.cc
index cf479b91c5f94a1f69822a1b66b048dc1c7c7de4..bdf3d90ec0e09f8636d51ccac0ee949b56f60615 100644
--- a/components/crash/app/crash_reporter_client.cc
+++ b/components/crash/app/crash_reporter_client.cc
@@ -118,6 +118,20 @@ bool CrashReporterClient::ReportingIsEnforcedByPolicy(bool* breakpad_enabled) {
int CrashReporterClient::GetAndroidMinidumpDescriptor() {
return 0;
}
+
+bool CrashReporterClient::ShouldEnableBreakpadMicrodumps() {
+// Always enable microdumps on Android when stripping unwind tables. Rationale:
+// when unwind tables are stripped out (to save binary size) the stack traces
+// produced locally in the case of a crash / CHECK are meaningless. In order to
+// provide meaningful development diagnostics (and keep the binary size savings)
+// on Android we attach a secondary crash handler which serializes a reduced
+// form of logcat on the console.
+#if defined(NO_UNWIND_TABLES)
+ return true;
+#else
+ return false;
+#endif
+}
#endif
#if defined(OS_MACOSX)
« no previous file with comments | « components/crash/app/crash_reporter_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698