Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Side by Side Diff: components/crash/app/crash_reporter_client.cc

Issue 904213002: [components/crash] Add crash client method to enable microdumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/crash/app/crash_reporter_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/crash/app/crash_reporter_client.h" 5 #include "components/crash/app/crash_reporter_client.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 namespace crash_reporter { 10 namespace crash_reporter {
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 #if defined(OS_WIN) || defined(OS_MACOSX) 111 #if defined(OS_WIN) || defined(OS_MACOSX)
112 bool CrashReporterClient::ReportingIsEnforcedByPolicy(bool* breakpad_enabled) { 112 bool CrashReporterClient::ReportingIsEnforcedByPolicy(bool* breakpad_enabled) {
113 return false; 113 return false;
114 } 114 }
115 #endif 115 #endif
116 116
117 #if defined(OS_ANDROID) 117 #if defined(OS_ANDROID)
118 int CrashReporterClient::GetAndroidMinidumpDescriptor() { 118 int CrashReporterClient::GetAndroidMinidumpDescriptor() {
119 return 0; 119 return 0;
120 } 120 }
121
122 bool CrashReporterClient::ShouldEnableBreakpadMicrodumps() {
123 // Always enable microdumps on Android when stripping unwind tables. Rationale:
124 // when unwind tables are stripped out (to save binary size) the stack traces
125 // produced locally in the case of a crash / CHECK are meaningless. In order to
126 // provide meaningful development diagnostics (and keep the binary size savings)
127 // on Android we attach a secondary crash handler which serializes a reduced
128 // form of logcat on the console.
129 #if defined(NO_UNWIND_TABLES)
130 return true;
131 #else
132 return false;
133 #endif
134 }
121 #endif 135 #endif
122 136
123 #if defined(OS_MACOSX) 137 #if defined(OS_MACOSX)
124 void CrashReporterClient::InstallAdditionalFilters(BreakpadRef breakpad) { 138 void CrashReporterClient::InstallAdditionalFilters(BreakpadRef breakpad) {
125 } 139 }
126 #endif 140 #endif
127 141
128 bool CrashReporterClient::EnableBreakpadForProcess( 142 bool CrashReporterClient::EnableBreakpadForProcess(
129 const std::string& process_type) { 143 const std::string& process_type) {
130 return false; 144 return false;
131 } 145 }
132 146
133 } // namespace crash_reporter 147 } // namespace crash_reporter
OLDNEW
« no previous file with comments | « components/crash/app/crash_reporter_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698