Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 90413002: Ensure that child FrameTreeNodes are deleted after a navigation or crash. (Closed)

Created:
7 years ago by Charlie Reis
Modified:
7 years ago
Reviewers:
nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Ensure that child FrameTreeNodes are deleted after a navigation or crash. BUG=245126 TEST=FrameTreeNodes deleted after a renderer crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -3 lines) Patch
M content/browser/frame_host/frame_tree_node.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 2 chunks +68 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Nasko: these are the changes I added in patch set 3 of https://codereview.chromium.org/82033002/. I had ...
7 years ago (2013-11-27 02:57:12 UTC) #1
nasko
LGTM
7 years ago (2013-11-27 15:03:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/90413002/1
7 years ago (2013-11-27 16:42:30 UTC) #3
commit-bot: I haz the power
7 years ago (2013-11-27 18:17:11 UTC) #4
Message was sent while issue was closed.
Change committed as 237601

Powered by Google App Engine
This is Rietveld 408576698