Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 903943002: Mac: Make content shell work with remote CoreAnimation (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Make content shell work with remote CoreAnimation Move setting of NSWindowHostsLayersInWindowServer to ContentMainRunnerImpl::Initialize. Use the CoreFoundation API so that it can be called from C code. BUG=450173 Committed: https://crrev.com/c685e64c0d001f8bba7bd42c711e243bd57d3d59 Cr-Commit-Position: refs/heads/master@{#329366}

Patch Set 1 #

Patch Set 2 : Move to ContentMainRunnerImpl #

Total comments: 1

Patch Set 3 : Use NS-APIs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -7 lines) Patch
M chrome/browser/chrome_browser_main_mac.mm View 1 1 chunk +1 line, -7 lines 0 comments Download
M content/app/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/app/content_main_runner.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A content/app/mac/mac_init.h View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A content/app/mac/mac_init.mm View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M content/content_app.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
ccameron
I had let this drop off my radar. Small fix.
5 years, 10 months ago (2015-02-06 01:43:39 UTC) #2
Avi (use Gerrit)
:/ CA is used deep in the content layer. Isn't there some common initialization place ...
5 years, 10 months ago (2015-02-06 01:49:32 UTC) #3
ccameron
Fixed. For some reason I can't get Chromium.app to not host in the window server ...
5 years, 7 months ago (2015-05-07 19:42:01 UTC) #4
Avi (use Gerrit)
https://codereview.chromium.org/903943002/diff/20001/content/app/content_main_runner.cc File content/app/content_main_runner.cc (right): https://codereview.chromium.org/903943002/diff/20001/content/app/content_main_runner.cc#newcode570 content/app/content_main_runner.cc:570: key, value, kCFPreferencesCurrentApplication); CFPreferencesSetAppValue is different than -[NSUserDefaults registerDefaults:]. ...
5 years, 7 months ago (2015-05-07 19:54:44 UTC) #5
ccameron
On 2015/05/07 19:54:44, Avi wrote: > https://codereview.chromium.org/903943002/diff/20001/content/app/content_main_runner.cc > File content/app/content_main_runner.cc (right): > > https://codereview.chromium.org/903943002/diff/20001/content/app/content_main_runner.cc#newcode570 > ...
5 years, 7 months ago (2015-05-07 19:55:51 UTC) #6
ccameron
Okay, this should do it.
5 years, 7 months ago (2015-05-12 02:10:07 UTC) #7
Avi (use Gerrit)
lgtm
5 years, 7 months ago (2015-05-12 02:20:17 UTC) #8
ccameron
Thanks!
5 years, 7 months ago (2015-05-12 07:01:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903943002/40001
5 years, 7 months ago (2015-05-12 07:02:07 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 07:05:29 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 07:06:22 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c685e64c0d001f8bba7bd42c711e243bd57d3d59
Cr-Commit-Position: refs/heads/master@{#329366}

Powered by Google App Engine
This is Rietveld 408576698