Mac: Make content shell work with remote CoreAnimation

content/app/content_main_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/app/content_main_runner.h"
 
 #include <stdlib.h>
 
 #include "base/allocator/allocator_extension.h"
 #include "base/at_exit.h"
@@ skipping 65 matching lines @@
 #include <malloc.h>
 #include <cstring>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/trace_event/trace_event_etw_export_win.h"
 #include "ui/base/win/atl_module.h"
 #include "ui/gfx/win/dpi.h"
 #elif defined(OS_MACOSX)
 #include "base/mac/scoped_nsautorelease_pool.h"
 #if !defined(OS_IOS)
+#include <CoreFoundation/CoreFoundation.h>
+#include "base/mac/mac_util.h"
+#include "base/mac/scoped_cftyperef.h"
 #include "base/power_monitor/power_monitor_device_source.h"
+#include "base/strings/sys_string_conversions.h"
 #include "content/browser/mach_broker_mac.h"
 #include "content/common/sandbox_init_mac.h"
 #endif  // !OS_IOS
 #endif  // OS_WIN
 
 #if defined(OS_POSIX)
 #include <signal.h>
 
 #include "base/posix/global_descriptors.h"
 #include "content/public/common/content_descriptors.h"
@@ skipping 447 matching lines @@
 
     // Don't create this loop on iOS, since the outer loop is already handled
     // and a loop that's destroyed in shutdown interleaves badly with the event
     // loop pool on iOS.
 #if defined(OS_MACOSX) && !defined(OS_IOS)
     // We need this pool for all the objects created before we get to the
     // event loop, but we don't want to leave them hanging around until the
     // app quits. Each "main" needs to flush this pool right before it goes into
     // its main event loop to get rid of the cruft.
     autorelease_pool_.reset(new base::mac::ScopedNSAutoreleasePool());
+
+    // CoreAnimation has poor performance and CoreAnimation and
+    // non-CoreAnimation exhibit window flickering when layers are not hosted
+    // in the window server, which is the default when not not using the
+    // 10.9 SDK.
+    // TODO: Remove this when we build with the 10.9 SDK (or higher).
+    if (base::mac::IsOSMavericksOrLater()) {
+      base::ScopedCFTypeRef<CFStringRef> key(base::SysUTF8ToCFStringRef(
+          "NSWindowHostsLayersInWindowServer"));
+      base::ScopedCFTypeRef<CFStringRef> value(base::SysUTF8ToCFStringRef(
+          "YES"));
+      CFPreferencesSetAppValue(
+          key, value, kCFPreferencesCurrentApplication);

[Avi (use Gerrit), 2015/05/07 19:54:44]

CFPreferencesSetAppValue is different than -[NSUserDefaults registerDefaults:].
We don't want to actually save these values, just register them. (This has
bitten us in the past.)

-[NSUserDefaults registerDefaults:] puts the values in the NSRegistrationDomain,
and I can't figure out how to do that with CFPreferences.

+    }
 #endif
 
     // On Android, the command line is initialized when library is loaded and
     // we have already started our TRACE_EVENT0.
 #if !defined(OS_ANDROID)
     // argc/argv are ignored on Windows and Android; see command_line.h for
     // details.
     int argc = 0;
     const char** argv = NULL;
 
@@ skipping 278 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl);
 };
 
 // static
 ContentMainRunner* ContentMainRunner::Create() {
   return new ContentMainRunnerImpl();
 }
 
 }  // namespace content