Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 903713002: Fix titles shifting to the right as favicons are loading in Site Settings. (Closed)

Created:
5 years, 10 months ago by Finnur
Modified:
5 years, 10 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix titles shifting to the right as favicons are loading in Site Settings. BUG=453626 Committed: https://crrev.com/ffee96aecca98e07fe790fd064722390c04d7d42 Cr-Commit-Position: refs/heads/master@{#314837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Finnur
PTAL
5 years, 10 months ago (2015-02-05 13:19:45 UTC) #2
newt (away)
lgtm. Thanks for fixing :)
5 years, 10 months ago (2015-02-05 17:56:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903713002/1
5 years, 10 months ago (2015-02-05 17:57:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 18:21:12 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 18:22:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffee96aecca98e07fe790fd064722390c04d7d42
Cr-Commit-Position: refs/heads/master@{#314837}

Powered by Google App Engine
This is Rietveld 408576698