Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java

Issue 903713002: Fix titles shifting to the right as favicons are loading in Site Settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java
index 79b615a6e9ab39d9618fbb7a104d91abefcd5eac..f2116ab2f69f19d97c48c6d2692eb53c357b4853 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreference.java
@@ -6,7 +6,9 @@ package org.chromium.chrome.browser.preferences.website;
import android.content.Context;
import android.graphics.Bitmap;
+import android.graphics.Color;
import android.graphics.drawable.BitmapDrawable;
+import android.graphics.drawable.ColorDrawable;
import android.net.Uri;
import android.preference.Preference;
import android.view.View;
@@ -57,6 +59,18 @@ class WebsitePreference extends Preference implements FaviconImageCallback {
mCategoryFilter = categoryFilter;
mFilter = new WebsiteSettingsCategoryFilter();
setWidgetLayoutResource(R.layout.website_features);
+
+ // To make sure the layout stays stable throughout, we assign a
+ // transparent drawable of the same size as the favicon. This is so that
+ // we can fetch the favicon in the background and not have to worry
+ // about the title appearing to jump (http://crbug.com/453626) when the
+ // favicon becomes available.
+ ColorDrawable drawable = new ColorDrawable(Color.TRANSPARENT);
+ int size = Math.round(FAVICON_SIZE_DP
+ * getContext().getResources().getDisplayMetrics().density);
+ drawable.setBounds(0, 0, size, size);
+ setIcon(drawable);
+
refresh();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698