Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 903663002: Encrypted Media: Replace web_session_id with session_id (Closed)

Created:
5 years, 10 months ago by zhuoyu.qian
Modified:
5 years, 10 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, eme-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Encrypted Media: Replace web_session_id with session_id Now we don't have the integer session_id anymore, there's no need to have a separate name. So rename web_session_id to session_id. BUG=440510 R=xhwang@chromium.org Committed: https://crrev.com/c0b80de1f748956ed744d35c4c884e373dad8a53 Cr-Commit-Position: refs/heads/master@{#317986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chromecast/media/cdm/browser_cdm_cast.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromecast/media/cdm/browser_cdm_cast.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
zhuoyu.qian
5 years, 10 months ago (2015-02-05 09:26:47 UTC) #1
gunsch
On 2015/02/05 09:26:47, zhuoyu.qian wrote: xhwang@ can't approve code in chromecast/ :) chromecast/ lgtm
5 years, 10 months ago (2015-02-05 16:37:57 UTC) #2
xhwang
non-owner lgtm :)
5 years, 10 months ago (2015-02-05 17:51:42 UTC) #3
zhuoyu.qian
I'd like you to do a code review. Please visit https://codereview.chromium.org/903663002 to have a look. ...
5 years, 10 months ago (2015-02-06 02:59:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903663002/1
5 years, 10 months ago (2015-02-09 09:51:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/41346)
5 years, 10 months ago (2015-02-09 09:55:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903663002/1
5 years, 10 months ago (2015-02-25 05:22:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 05:28:32 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 05:29:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0b80de1f748956ed744d35c4c884e373dad8a53
Cr-Commit-Position: refs/heads/master@{#317986}

Powered by Google App Engine
This is Rietveld 408576698