Issue 90363003: Get rid of useless calls to AtomicString::impl()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 90363003: Get rid of useless calls to AtomicString::impl() (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, Nate Chapin, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Get rid of useless calls to AtomicString::impl() Get rid of useless calls to AtomicString::impl() in the code. This avoids uselessly calling AtomicString(StringImpl*) constructor in several cases. R=abarth BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162750

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	Source/core/css/RuleFeature.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/SelectorCheckerFastPath.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/StyleBuilderCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLFormElement.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/forms/FormController.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/loader/DocumentLoader.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/90363003/1

7 years ago (2013-11-27 02:38:29 UTC) #3

Message was sent while issue was closed.

Change committed as 162750

Expand Messages | Collapse Messages