Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 90363003: Get rid of useless calls to AtomicString::impl()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 90363003: Get rid of useless calls to AtomicString::impl() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/Source/core/css/resolver/StyleBuilderCustom.cpp b/Source/core/css/resolver/StyleBuilderCustom.cpp

index a4e8a8485a6b414d6eaa16221cb798eb5368150e..8743c523d2256a9a7e62297941339e7ed722053e 100644

--- a/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -1385,7 +1385,7 @@ void StyleBuilder::oldApplyProperty(CSSPropertyID id, StyleResolverState& state,

state.parentStyle()->setUnique();

QualifiedName attr(nullAtom, contentValue->getStringValue().impl(), nullAtom);

const AtomicString& value = state.element()->getAttribute(attr);

- state.style()->setContent(value.isNull() ? emptyAtom : value.impl(), didSet);

+ state.style()->setContent(value.isNull() ? emptyString() : value.string(), didSet);

didSet = true;

// register the fact that the attribute value affects the style

state.contentAttrValues().append(attr.localName());

« no previous file with comments | « Source/core/css/SelectorCheckerFastPath.cpp ('k') | Source/core/html/HTMLElement.h » ('j') | no next file with comments »