Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 903553004: Re-enable sandboxing on the Clang ASan Windows bots +tests (Closed)

Created:
5 years, 10 months ago by Timur Iskhodzhanov
Modified:
5 years, 10 months ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable sandboxing on the Clang ASan Windows bots +tests This should work fine now that Chrome and sandbox tests behave in an ASan-friendly way. This effectively reverts r313452 and r312495 BUG=382867 TBR=thakis@chromium.org,scottmg@chromium.org NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/fdbfd4e151cbf48047a9485130c9122f84607978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M testing/buildbot/chromium.fyi.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/test_env.py View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Timur Iskhodzhanov
TBR
5 years, 10 months ago (2015-02-05 12:37:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903553004/1
5 years, 10 months ago (2015-02-05 12:38:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903553004/1
5 years, 10 months ago (2015-02-05 12:44:06 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fdbfd4e151cbf48047a9485130c9122f84607978 Cr-Commit-Position: refs/heads/master@{#314790}
5 years, 10 months ago (2015-02-05 13:52:49 UTC) #7
Timur Iskhodzhanov
Committed patchset #1 (id:1) manually as fdbfd4e151cbf48047a9485130c9122f84607978.
5 years, 10 months ago (2015-02-05 13:52:58 UTC) #8
Nico
5 years, 10 months ago (2015-02-05 15:05:17 UTC) #9
Message was sent while issue was closed.
ah, you did this already too :-) lgtm

Powered by Google App Engine
This is Rietveld 408576698