testing/test_env.py - Issue 903553004: Re-enable sandboxing on the Clang ASan Windows bots +tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/test_env.py

Issue 903553004: Re-enable sandboxing on the Clang ASan Windows bots +tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: testing/test_env.py

diff --git a/testing/test_env.py b/testing/test_env.py

index 48cbac97ce42b70fc17367e373470a21063f4540..597ca2ab2343e92762f8665f8040e9bc802d63ae 100755

--- a/testing/test_env.py

+++ b/testing/test_env.py

@@ -185,10 +185,9 @@ def run_executable(cmd, env):

if asan or lsan or msan or tsan:

extra_env.update(get_sanitizer_env(cmd, asan, lsan, msan, tsan))

- if lsan or tsan or (asan and sys.platform == 'win32'):

- # ASan is not yet sandbox-friendly on Windows (http://crbug.com/382867).

- # LSan and TSan are not sandbox-friendly.

- cmd.append('--no-sandbox')

+ if lsan or tsan:

+ # LSan and TSan are not sandbox-friendly.

+ cmd.append('--no-sandbox')

cmd = trim_cmd(cmd)

« no previous file with comments | « testing/buildbot/chromium.fyi.json ('k') | no next file » | no next file with comments »