Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 903553002: Correctly track texture cleared state for sharing (Closed)

Created:
5 years, 10 months ago by boliu
Modified:
5 years, 10 months ago
Reviewers:
boliu
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Target Ref:
refs/pending/branch-heads/2214
Project:
chromium
Visibility:
Public.

Description

Correctly track texture cleared state for sharing When sharing textures in mailboxes using MailboxManagerSync there's an optimization that if textures are not updated then there is no need to share it again. However the code that checks whether textures are updated ignores the cleared state, causing shared texture to remain uncleared indefinitely. Fix by check the cleared state. And add a unit test. BUG=453199 Review URL: https://codereview.chromium.org/890453002 Cr-Commit-Position: refs/heads/master@{#313814} (cherry picked from commit 2f4ff4807f5d7805a5658ceb7ba71072152ea6c9) TBR=boliu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ace97840db2a9fa237cdc6038070dfd3aa0bf160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M gpu/command_buffer/service/mailbox_manager_unittest.cc View 2 chunks +52 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
boliu
5 years, 10 months ago (2015-02-04 21:59:36 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ace97840db2a9fa237cdc6038070dfd3aa0bf160 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698