Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 890453002: Correctly track texture cleared state when sharing (Closed)

Created:
5 years, 10 months ago by boliu
Modified:
5 years, 10 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly track texture cleared state for sharing When sharing textures in mailboxes using MailboxManagerSync there's an optimization that if textures are not updated then there is no need to share it again. However the code that checks whether textures are updated ignores the cleared state, causing shared texture to remain uncleared indefinitely. Fix by check the cleared state. And add a unit test. BUG=453199 Committed: https://crrev.com/2f4ff4807f5d7805a5658ceb7ba71072152ea6c9 Cr-Commit-Position: refs/heads/master@{#313814}

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : blank line #

Total comments: 2

Patch Set 4 : c++11 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -1 line) Patch
M gpu/command_buffer/service/mailbox_manager_unittest.cc View 1 2 chunks +52 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 2 3 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
boliu
ptal :)
5 years, 10 months ago (2015-01-29 03:04:32 UTC) #2
no sievers
lgtm! https://codereview.chromium.org/890453002/diff/40001/gpu/command_buffer/service/texture_definition.cc File gpu/command_buffer/service/texture_definition.cc (right): https://codereview.chromium.org/890453002/diff/40001/gpu/command_buffer/service/texture_definition.cc#newcode431 gpu/command_buffer/service/texture_definition.cc:431: for (size_t j = 0; j < face_info.size(); ...
5 years, 10 months ago (2015-01-29 20:23:50 UTC) #3
boliu
https://codereview.chromium.org/890453002/diff/40001/gpu/command_buffer/service/texture_definition.cc File gpu/command_buffer/service/texture_definition.cc (right): https://codereview.chromium.org/890453002/diff/40001/gpu/command_buffer/service/texture_definition.cc#newcode431 gpu/command_buffer/service/texture_definition.cc:431: for (size_t j = 0; j < face_info.size(); ++j) ...
5 years, 10 months ago (2015-01-29 22:04:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890453002/60001
5 years, 10 months ago (2015-01-29 22:05:23 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-29 23:01:09 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 23:02:01 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2f4ff4807f5d7805a5658ceb7ba71072152ea6c9
Cr-Commit-Position: refs/heads/master@{#313814}

Powered by Google App Engine
This is Rietveld 408576698