Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 903463002: Simplify WeakMap and WeakSet tests slightly. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
rossberg, yurys
CC:
v8-dev, yurys
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify WeakMap and WeakSet tests slightly. R=rossberg@chromium.org TEST=cctest/test-weakmaps,cctest/test-weaksets Committed: https://crrev.com/a90d7a871da19d33e93c8779186408c8d1615cac Cr-Commit-Position: refs/heads/master@{#26428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -27 lines) Patch
M test/cctest/test-weakmaps.cc View 5 chunks +8 lines, -13 lines 0 comments Download
M test/cctest/test-weaksets.cc View 5 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-04 13:14:44 UTC) #1
rossberg
lgtm
5 years, 10 months ago (2015-02-04 13:16:00 UTC) #2
yurys
lgtm, I should have done it in my CL.
5 years, 10 months ago (2015-02-04 13:16:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903463002/1
5 years, 10 months ago (2015-02-04 13:20:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 13:36:55 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a90d7a871da19d33e93c8779186408c8d1615cac Cr-Commit-Position: refs/heads/master@{#26428}
5 years, 10 months ago (2015-02-04 13:37:14 UTC) #8
yurys
5 years, 10 months ago (2015-02-04 15:10:36 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/899833003/ by yurys@chromium.org.

The reason for reverting is: Revert this patch as the original CL has to be
reverted to due to shared win build failure

http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20....

Powered by Google App Engine
This is Rietveld 408576698