Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: test/cctest/test-weaksets.cc

Issue 903463002: Simplify WeakMap and WeakSet tests slightly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-weakmaps.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-weaksets.cc
diff --git a/test/cctest/test-weaksets.cc b/test/cctest/test-weaksets.cc
index 60f2d45dc358d8c186bc139a943763db21e39f38..f08a99bcbfa250f8f4c1584379c3bdf101bf17ab 100644
--- a/test/cctest/test-weaksets.cc
+++ b/test/cctest/test-weaksets.cc
@@ -55,12 +55,6 @@ static Handle<JSWeakSet> AllocateJSWeakSet(Isolate* isolate) {
return weakset;
}
-static void PutIntoWeakSet(Handle<JSWeakSet> weakset,
- Handle<JSObject> key,
- Handle<Object> value) {
- Runtime::WeakCollectionSet(weakset, key, value);
-}
-
static int NumberOfWeakCalls = 0;
static void WeakPointerCallback(
const v8::WeakCallbackData<v8::Value, void>& data) {
@@ -96,9 +90,8 @@ TEST(WeakSet_Weakness) {
// Put entry into weak set.
{
HandleScope scope(isolate);
- PutIntoWeakSet(weakset,
- Handle<JSObject>(JSObject::cast(*key)),
- Handle<Smi>(Smi::FromInt(23), isolate));
+ Handle<Smi> smi(Smi::FromInt(23), isolate);
+ Runtime::WeakCollectionSet(weakset, key, smi);
}
CHECK_EQ(1, ObjectHashTable::cast(weakset->table())->NumberOfElements());
@@ -152,7 +145,8 @@ TEST(WeakSet_Shrinking) {
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
for (int i = 0; i < 32; i++) {
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
- PutIntoWeakSet(weakset, object, Handle<Smi>(Smi::FromInt(i), isolate));
+ Handle<Smi> smi(Smi::FromInt(i), isolate);
+ Runtime::WeakCollectionSet(weakset, object, smi);
}
}
@@ -199,7 +193,7 @@ TEST(WeakSet_Regress2060a) {
Handle<JSObject> object = factory->NewJSObject(function, TENURED);
CHECK(!heap->InNewSpace(object->address()));
CHECK(!first_page->Contains(object->address()));
- PutIntoWeakSet(weakset, key, object);
+ Runtime::WeakCollectionSet(weakset, key, object);
}
}
@@ -239,9 +233,8 @@ TEST(WeakSet_Regress2060b) {
}
Handle<JSWeakSet> weakset = AllocateJSWeakSet(isolate);
for (int i = 0; i < 32; i++) {
- PutIntoWeakSet(weakset,
- keys[i],
- Handle<Smi>(Smi::FromInt(i), isolate));
+ Handle<Smi> smi(Smi::FromInt(i), isolate);
+ Runtime::WeakCollectionSet(weakset, keys[i], smi);
}
// Force compacting garbage collection. The subsequent collections are used
« no previous file with comments | « test/cctest/test-weakmaps.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698