Issue 903453002: Policy: check MustRemainInstalled in addition to UserMayModifySettings before offering uninstall

Issue 903453002: Policy: check MustRemainInstalled in addition to UserMayModifySettings before offering uninstall (Closed)

Created:
5 years, 10 months ago by Marc Treib

Modified:
5 years, 10 months ago

Reviewers:
binjin, benwells

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Policy: check MustRemainInstalled in addition to UserMayModifySettings before offering uninstall Committed: https://crrev.com/5dec37c6a3517ccf5343f0ef11e332b6ba1cb0bd Cr-Commit-Position: refs/heads/master@{#314784}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -8 lines)			Patch
M	chrome/browser/extensions/extension_context_menu_model.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	extensions/browser/api/management/management_api.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 10 (3 generated)

Marc Treib

Hi binjin, CL as discussed! PTAL as the MustRemainInstalled author. I'll add OWNERS once you're ...

5 years, 10 months ago (2015-02-04 13:06:26 UTC) #2

Marc Treib

Hi benwells, can I get an OWNERS review please? Thanks!

5 years, 10 months ago (2015-02-04 13:14:16 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903453002/1

5 years, 10 months ago (2015-02-05 08:56:29 UTC) #8

commit-bot: I haz the power

5 years, 10 months ago (2015-02-05 09:48:17 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5dec37c6a3517ccf5343f0ef11e332b6ba1cb0bd
Cr-Commit-Position: refs/heads/master@{#314784}