chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc - Issue 903453002: Policy: check MustRemainInstalled in addition to UserMayModifySettings before offering uninstall

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

Issue 903453002: Policy: check MustRemainInstalled in addition to UserMayModifySettings before offering uninstall (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.cc ('k') | extensions/browser/api/management/management_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

index 84112a38277a47a9714a38216329e1a59369ffb8..733f20dc1d34a7076e8404524c67fc06deecb99a 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

@@ -184,7 +184,8 @@ void AppInfoFooterPanel::UninstallApp() {

}

bool AppInfoFooterPanel::CanUninstallApp() const {

- return extensions::ExtensionSystem::Get(profile_)

- ->management_policy()

- ->UserMayModifySettings(app_, NULL);

+ extensions::ManagementPolicy* policy =

+ extensions::ExtensionSystem::Get(profile_)->management_policy();

+ return policy->UserMayModifySettings(app_, nullptr) &&

+ !policy->MustRemainInstalled(app_, nullptr);

}

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.cc ('k') | extensions/browser/api/management/management_api.cc » ('j') | no next file with comments »