Make FontList description-parsing public.

Make FontList description-parsing public.

Move FontListImpl's description-string-parsing code into a
static FontList::ParseDescription() method that
PlatformFontPango will be able to call to parse descriptions
on Chrome OS.

Also make parsing stricter, add tests, and delete unused
SetUpPangoLayout() and GetFontDescriptionString().

BUG=398885, 393067
Committed: https://crrev.com/23144a693589b55017e863a60ae09a2edd7c3284
Cr-Commit-Position: refs/heads/master@{#315559}

[Daniel Erat, 2015-02-08 15:47:47]

derat@chromium.org changed reviewers:
+ msw@chromium.org, yukishiino@chromium.org

[Yuki, 2015-02-09 04:41:29]

lgtm

https://codereview.chromium.org/903423002/diff/60001/ui/gfx/font_list.cc
File ui/gfx/font_list.cc (right):

https://codereview.chromium.org/903423002/diff/60001/ui/gfx/font_list.cc#newc...
ui/gfx/font_list.cc:40: for (auto it = families_out->begin(); it !=
families_out->end(); ++it)
Could you use the following form?

  for (auto& family : *families_out)
    base::TrimWhitespaceASCII(family, base::TRIM_ALL, &family);

[Daniel Erat, 2015-02-09 16:23:47]

https://codereview.chromium.org/903423002/diff/60001/ui/gfx/font_list.cc
File ui/gfx/font_list.cc (right):

https://codereview.chromium.org/903423002/diff/60001/ui/gfx/font_list.cc#newc...
ui/gfx/font_list.cc:40: for (auto it = families_out->begin(); it !=
families_out->end(); ++it)
On 2015/02/09 04:41:29, Yuki wrote:
> Could you use the following form?
> 
>   for (auto& family : *families_out)
>     base::TrimWhitespaceASCII(family, base::TRIM_ALL, &family);

sure, done. thanks for the quick review!

[Daniel Erat, 2015-02-09 16:24:17]

New patchsets have been uploaded after l-g-t-m from yukishiino@chromium.org

[msw, 2015-02-10 00:30:38]

lgtm with #include removal nits.

https://codereview.chromium.org/903423002/diff/80001/ui/gfx/pango_util.cc
File ui/gfx/pango_util.cc (right):

https://codereview.chromium.org/903423002/diff/80001/ui/gfx/pango_util.cc#new...
ui/gfx/pango_util.cc:10: #include <string>
nit: I think you can remove this.

https://codereview.chromium.org/903423002/diff/80001/ui/gfx/pango_util.cc#new...
ui/gfx/pango_util.cc:15: #include "base/logging.h"
nit: I think you can remove this.

https://codereview.chromium.org/903423002/diff/80001/ui/gfx/pango_util.cc#new...
ui/gfx/pango_util.cc:16: #include "base/strings/utf_string_conversions.h"
nit: I think you can remove this.

https://codereview.chromium.org/903423002/diff/80001/ui/gfx/pango_util.cc#new...
ui/gfx/pango_util.cc:17: #include "ui/gfx/canvas.h"
nit: I think you can remove this.

https://codereview.chromium.org/903423002/diff/80001/ui/gfx/pango_util.cc#new...
ui/gfx/pango_util.cc:18: #include "ui/gfx/font_list.h"
nit: I think you can remove this.

https://codereview.chromium.org/903423002/diff/80001/ui/gfx/pango_util.cc#new...
ui/gfx/pango_util.cc:19: #include "ui/gfx/font_render_params.h"
nit: I think you can remove this.

https://codereview.chromium.org/903423002/diff/80001/ui/gfx/pango_util.cc#new...
ui/gfx/pango_util.cc:21: #include "ui/gfx/platform_font_pango.h"
nit: I think you can remove this.

https://codereview.chromium.org/903423002/diff/80001/ui/gfx/pango_util.cc#new...
ui/gfx/pango_util.cc:22: #include "ui/gfx/text_utils.h"
nit: I think you can remove this.

[Daniel Erat, 2015-02-10 01:43:21]

if it's okay with you, i'm leaving those for now since i'm deleting
pango_utils.* in the next change. :-)

[Daniel Erat, 2015-02-10 01:43:27]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2015-02-10 01:44:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/903423002/80001

[commit-bot: I haz the power, 2015-02-10 01:50:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-10 01:50:06]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Daniel Erat, 2015-02-10 02:01:02]

derat@chromium.org changed reviewers:
+ sky@chromium.org

[Daniel Erat, 2015-02-10 02:01:03]

scott, mind looking at ui/base/resource?

[sky, 2015-02-10 14:26:18]

ui/base/resource LGTM

[Daniel Erat, 2015-02-10 14:44:44]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2015-02-10 14:44:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/903423002/80001

[commit-bot: I haz the power, 2015-02-10 14:48:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-10 14:49:15]

Patchset 5 (id:??) landed as
https://crrev.com/23144a693589b55017e863a60ae09a2edd7c3284
Cr-Commit-Position: refs/heads/master@{#315559}