Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: ui/gfx/font_list_impl.h

Issue 903423002: Make FontList description-parsing public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge and apply review feedback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/font_list_impl.h
diff --git a/ui/gfx/font_list_impl.h b/ui/gfx/font_list_impl.h
index 94bb33036abfa0cd576de8ef2ed287f0a127575c..cd8e58c9110ce772b96aa9381a1389b0b697ada0 100644
--- a/ui/gfx/font_list_impl.h
+++ b/ui/gfx/font_list_impl.h
@@ -70,11 +70,6 @@ class FontListImpl : public base::RefCounted<FontListImpl> {
// Returns the |gfx::Font::FontStyle| style flags for this font list.
int GetFontStyle() const;
- // Returns a string representing font names, styles, and size. If the
- // FontListImpl is initialized by a vector of Font, use the first font's style
- // and size for the description.
- const std::string& GetFontDescriptionString() const;
-
// Returns the font size in pixels.
int GetFontSize() const;
@@ -107,6 +102,8 @@ class FontListImpl : public base::RefCounted<FontListImpl> {
// If FontListImpl is constructed with a vector of font,
// |font_description_string_| is not initialized during construction. Instead,
// it is computed lazily when user asked to get the font description string.
+ //
+ // TODO(derat): Remove laziness so that this can be removed.
mutable std::string font_description_string_;
// The cached common height and baseline of the fonts in the font list.
« no previous file with comments | « ui/gfx/font_list.cc ('k') | ui/gfx/font_list_impl.cc » ('j') | ui/gfx/pango_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698