runtime/bin/dartutils.cc - Issue 9034005: Change the behavior of open on files to not truncate by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/dartutils.cc

Issue 9034005: Change the behavior of open on files to not truncate by default (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comment.s Created 8 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/dartutils.cc

diff --git a/runtime/bin/dartutils.cc b/runtime/bin/dartutils.cc

index 9927c1a79e310a0749dd7e8a2f17bd3440af2a67..00f09564e4d2884eb65d38b742d61e69c8ee71ac 100644

--- a/runtime/bin/dartutils.cc

+++ b/runtime/bin/dartutils.cc

@@ -130,7 +130,7 @@ Dart_Handle DartUtils::CanonicalizeURL(CommandLineOptions* url_mapping,

Dart_Handle DartUtils::ReadStringFromFile(const char* filename) {

- File* file = File::Open(filename, false);

+ File* file = File::Open(filename, File::kRead);

if (file == NULL) {

const char* format = "Unable to open file: %s";

intptr_t len = snprintf(NULL, 0, format, filename);

« no previous file with comments | « no previous file | runtime/bin/file.h » ('j') | no next file with comments »