Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Side by Side Diff: runtime/bin/dartutils.cc

Issue 9034005: Change the behavior of open on files to not truncate by default (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comment.s Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/bin/file.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/dartutils.h" 5 #include "bin/dartutils.h"
6 6
7 #include "bin/file.h" 7 #include "bin/file.h"
8 #include "bin/globals.h" 8 #include "bin/globals.h"
9 9
10 const char* DartUtils::kDartScheme = "dart:"; 10 const char* DartUtils::kDartScheme = "dart:";
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 // Calculate the canonical path. 123 // Calculate the canonical path.
124 const char* canon_url_str = GetCanonicalPath(library_url_str, url_str); 124 const char* canon_url_str = GetCanonicalPath(library_url_str, url_str);
125 Dart_Handle canon_url = Dart_NewString(canon_url_str); 125 Dart_Handle canon_url = Dart_NewString(canon_url_str);
126 free(const_cast<char*>(canon_url_str)); 126 free(const_cast<char*>(canon_url_str));
127 127
128 return canon_url; 128 return canon_url;
129 } 129 }
130 130
131 131
132 Dart_Handle DartUtils::ReadStringFromFile(const char* filename) { 132 Dart_Handle DartUtils::ReadStringFromFile(const char* filename) {
133 File* file = File::Open(filename, false); 133 File* file = File::Open(filename, File::kRead);
134 if (file == NULL) { 134 if (file == NULL) {
135 const char* format = "Unable to open file: %s"; 135 const char* format = "Unable to open file: %s";
136 intptr_t len = snprintf(NULL, 0, format, filename); 136 intptr_t len = snprintf(NULL, 0, format, filename);
137 // TODO(iposva): Allocate from the zone instead of leaking error string 137 // TODO(iposva): Allocate from the zone instead of leaking error string
138 // here. On the other hand the binary is about the exit anyway. 138 // here. On the other hand the binary is about the exit anyway.
139 char* error_msg = reinterpret_cast<char*>(malloc(len + 1)); 139 char* error_msg = reinterpret_cast<char*>(malloc(len + 1));
140 snprintf(error_msg, len + 1, format, filename); 140 snprintf(error_msg, len + 1, format, filename);
141 return Dart_Error(error_msg); 141 return Dart_Error(error_msg);
142 } 142 }
143 intptr_t len = file->Length(); 143 intptr_t len = file->Length();
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 path, File::PathSeparator(), filename); 213 path, File::PathSeparator(), filename);
214 214
215 free(path); 215 free(path);
216 char* canonical_filename = File::GetCanonicalPath(absolute_filename); 216 char* canonical_filename = File::GetCanonicalPath(absolute_filename);
217 if (canonical_filename == NULL) { 217 if (canonical_filename == NULL) {
218 return absolute_filename; 218 return absolute_filename;
219 } 219 }
220 free(absolute_filename); 220 free(absolute_filename);
221 return canonical_filename; 221 return canonical_filename;
222 } 222 }
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/file.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698