Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 903363003: [WebView] Reword crash handler message. (Closed)

Created:
5 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Reword crash handler message. The current crash handler prints a message on logcat of the form "### WebView crash. Version ..." whenever a crash is detected in an Android app which happens to have a WebView. Due to the in-process nature of the WebView, the crash handler is triggered regardless of the actual cause of the crash, which might be totally unrelated with the WebView or the chromium codebase at all. The current wording is misleading as it erroneously suggests that the crash is always due to the WebView. BUG=456485 TBR=torne@chromium.org Committed: https://crrev.com/86fca587a88a12c485c5b3bfaf7d3029561137af Cr-Commit-Position: refs/heads/master@{#315210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/common/aw_crash_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903363003/1
5 years, 10 months ago (2015-02-07 15:49:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 16:11:13 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86fca587a88a12c485c5b3bfaf7d3029561137af Cr-Commit-Position: refs/heads/master@{#315210}
5 years, 10 months ago (2015-02-07 16:11:50 UTC) #5
Torne
5 years, 10 months ago (2015-02-08 15:03:34 UTC) #6
Message was sent while issue was closed.
LGTM - can you also land this in m40 downstream?

Powered by Google App Engine
This is Rietveld 408576698