Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Side by Side Diff: android_webview/common/aw_crash_handler.cc

Issue 903363003: [WebView] Reword crash handler message. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/common/aw_crash_handler.h" 5 #include "android_webview/common/aw_crash_handler.h"
6 6
7 #include <android/log.h> 7 #include <android/log.h>
8 #include <signal.h> 8 #include <signal.h>
9 #include <sys/prctl.h> 9 #include <sys/prctl.h>
10 #include <sys/syscall.h> 10 #include <sys/syscall.h>
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 namespace android_webview { 65 namespace android_webview {
66 namespace crash_handler { 66 namespace crash_handler {
67 67
68 void RegisterCrashHandler(const std::string& version) { 68 void RegisterCrashHandler(const std::string& version) {
69 if (crash_handler_registered) { 69 if (crash_handler_registered) {
70 NOTREACHED(); 70 NOTREACHED();
71 return; 71 return;
72 } 72 }
73 73
74 g_crash_msg = "### WebView crash. " + version; 74 g_crash_msg = "### WebView " + version;
75 g_crash_msg_ptr = g_crash_msg.c_str(); 75 g_crash_msg_ptr = g_crash_msg.c_str();
76 76
77 // Fail if unable to store all the old handlers. 77 // Fail if unable to store all the old handlers.
78 for (uint32_t i = 0; i < arraysize(kExceptionSignals); ++i) { 78 for (uint32_t i = 0; i < arraysize(kExceptionSignals); ++i) {
79 if (sigaction(kExceptionSignals[i], NULL, &old_handlers[i]) == -1) { 79 if (sigaction(kExceptionSignals[i], NULL, &old_handlers[i]) == -1) {
80 LOG(ERROR) << "Error while trying to retrieve old handler for signal " 80 LOG(ERROR) << "Error while trying to retrieve old handler for signal "
81 << kExceptionSignals[i] << ")"; 81 << kExceptionSignals[i] << ")";
82 return; 82 return;
83 } 83 }
84 } 84 }
(...skipping 16 matching lines...) Expand all
101 LOG(ERROR) << "Error while overriding handler for signal " 101 LOG(ERROR) << "Error while overriding handler for signal "
102 << kExceptionSignals[i]; 102 << kExceptionSignals[i];
103 } 103 }
104 } 104 }
105 105
106 crash_handler_registered = true; 106 crash_handler_registered = true;
107 } 107 }
108 108
109 } // namespace crash_handler 109 } // namespace crash_handler
110 } // namespace android_webview 110 } // namespace android_webview
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698