Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

Issue 903213003: Enable QUIC for proxies based on Finch config and command line switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments and removed code duplication. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
index f8be3741a8db30891dc9ec31d91cd2e539cb0ecb..d20f8c4a3f525dd53f6e84fcf0c3851c37a2d3e0 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
@@ -41,6 +41,15 @@ TEST_F(DataReductionProxySettingsTest, TestGetDataReductionProxyOrigin) {
EXPECT_EQ(expected_params_->DefaultOrigin(), result);
}
+TEST_F(DataReductionProxySettingsTest, TestGetDataReductionProxyOrigin2) {
+ // SetUp() adds the origin to the command line, which should be returned here.
+
+ std::string result =
+ settings_->params()->origin().ToURI();
+ EXPECT_EQ(expected_params_->DefaultOrigin(), result);
+}
+
+
TEST_F(DataReductionProxySettingsTest, TestGetDataReductionProxyDevOrigin) {
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
switches::kDataReductionProxyDev, expected_params_->DefaultDevOrigin());
@@ -425,7 +434,8 @@ TEST_F(DataReductionProxySettingsTest, CheckInitMetricsWhenNotAllowed) {
&pref_service_,
request_context.get(),
&net_log_,
- event_store_.get());
+ event_store_.get(),
+ true);
settings_->SetOnDataReductionEnabledCallback(
base::Bind(&DataReductionProxySettingsTestBase::
RegisterSyntheticFieldTrialCallback,

Powered by Google App Engine
This is Rietveld 408576698