components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc - Issue 903213003: Enable QUIC for proxies based on Finch config and command line switch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

Issue 903213003: Enable QUIC for proxies based on Finch config and command line switch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments and removed code duplication. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc » ('j') | components/data_reduction_proxy/core/common/data_reduction_proxy_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

index 053b0bcde26d9b861fc3f4e7fd025b37dc17c6ab..a11002dc3825d176540fead6c0c5d7d093707fbd 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

@@ -269,11 +269,9 @@ void DataReductionProxySettingsTestBase::CheckInitDataReductionProxy(

scoped_refptr<net::TestURLRequestContextGetter> request_context =

new net::TestURLRequestContextGetter(base::MessageLoopProxy::current());

- settings_->InitDataReductionProxySettings(

- &pref_service_,

- request_context.get(),

- &net_log_,

- event_store_.get());

+ settings_->InitDataReductionProxySettings(&pref_service_,

+ request_context.get(), &net_log_,

+ event_store_.get(), true);

bengr 2015/02/10 20:18:31 Do we also test with quic off?

tbansal1 2015/02/10 22:24:38 Added in data_reduction_proxy_settings_unittest.cc

settings_->SetOnDataReductionEnabledCallback(

base::Bind(&DataReductionProxySettingsTestBase::

RegisterSyntheticFieldTrialCallback,