Issue 90293002: Merge 162300 "Make second argument to CSSStyleSheet.insertRule() optional again"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 90293002: Merge 162300 "Make second argument to CSSStyleSheet.insertRule() optional again" (Closed)

Created:
7 years ago by tkent

Modified:
7 years ago

Reviewers:
Inactive

CC:
blink-reviews, arv+blink, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1700/

Visibility:
Public.

More Reviews

Description

Merge 162300 "Make second argument to CSSStyleSheet.insertRule() optional again" > Make second argument to CSSStyleSheet.insertRule() optional again to restore > backward compatibility. Also add a deprecation warning as passing only one > argument to CSSStyleSheet.insertRule() is incompatible with the standard > specification and with other major browsers. > > Making the arguments mandatory was done in r157074 but broke a popular > jQuery plugin. > > BUG=319695 > R=tkent > > Review URL: https://codereview.chromium.org/63883004 BUG=319695 TBR=ch.dumez@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162719

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -3 lines)			Patch
M	LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSStyleSheet.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/CSSStyleSheet.cpp	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSStyleSheet.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/UseCounter.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/page/UseCounter.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Inactive

7 years ago (2013-11-27 01:57:28 UTC) #2

Message was sent while issue was closed.

On 2013/11/27 01:54:11, tkent wrote:
> Committed patchset #1 manually as r162719.

LGTM, thanks.

Expand Messages | Collapse Messages