Make second argument to CSSStyleSheet.insertRule() optional again

Make second argument to CSSStyleSheet.insertRule() optional again

Make second argument to CSSStyleSheet.insertRule() optional again to restore
backward compatibility. Also add a deprecation warning as passing only one
argument to CSSStyleSheet.insertRule() is incompatible with the standard
specification and with other major browsers.

Making the arguments mandatory was done in r157074 but broke a popular
jQuery plugin.

BUG=319695
R=tkent

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162300

[Inactive, 2013-11-15 21:48:59]

If we want to go in this direction, the CL is ready.

[tkent, 2013-11-19 08:27:11]

lgtm
let's go ahead.

[commit-bot: I haz the power, 2013-11-19 08:27:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/63883004/30001

[commit-bot: I haz the power, 2013-11-19 08:27:52]

Failed to apply patch for Source/core/css/CSSStyleSheet.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/CSSStyleSheet.cpp
  Hunk #2 FAILED at 321.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/css/CSSStyleSheet.cpp.rej

Patch:       Source/core/css/CSSStyleSheet.cpp
Index: Source/core/css/CSSStyleSheet.cpp
diff --git a/Source/core/css/CSSStyleSheet.cpp
b/Source/core/css/CSSStyleSheet.cpp
index
c2a90d9c2f8059e4da547e4aaac3fca8ab5678b8..72f47dfb269f48a6d7cca3533b08d6187bf005e3
100644
--- a/Source/core/css/CSSStyleSheet.cpp
+++ b/Source/core/css/CSSStyleSheet.cpp
@@ -35,6 +35,7 @@
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/Node.h"
+#include "core/frame/UseCounter.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "wtf/text/StringBuilder.h"
@@ -320,6 +321,12 @@ unsigned CSSStyleSheet::insertRule(const String&
ruleString, unsigned index, Exc
     return index;
 }
 
+unsigned CSSStyleSheet::insertRule(const String& rule, ExceptionState& es)
+{
+    UseCounter::countDeprecation(activeExecutionContext(),
UseCounter::CSSStyleSheetInsertRuleOptionalArg);
+    return insertRule(rule, 0, es);
+}
+
 void CSSStyleSheet::deleteRule(unsigned index, ExceptionState& es)
 {
     ASSERT(m_childRuleCSSOMWrappers.isEmpty() ||
m_childRuleCSSOMWrappers.size() == m_contents->ruleCount());

[commit-bot: I haz the power, 2013-11-19 13:51:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/63883004/170001

[commit-bot: I haz the power, 2013-11-19 14:52:57]

Change committed as 162300