Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 902903002: NaCl: Remove use of NACL_BUILD_* in common.gypi. (Closed)

Created:
5 years, 10 months ago by teravest
Modified:
5 years, 10 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

NaCl: Remove use of NACL_BUILD_* in common.gypi. NACL_BUILD_ARCH and NACL_BUILD_SUBARCH are now supplied by build_config.h and need not come from the build system. TEST=Local build of chromium browser_tests on Linux x86_64, win_chromium_rel_ng trybot BUG=https://code.google.com/p/chromium/issues/detail?id=440012 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/9fff96b4342108d8865da8faabb9cea586449298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
teravest
Have any advice for other test coverage? win_chromium_rel_ng seems to be an x86_64 windows machine, ...
5 years, 10 months ago (2015-02-06 00:20:44 UTC) #2
Mark Seaborn
You have a stray word ("comments") in your commit message. LGTM otherwise. I think the ...
5 years, 10 months ago (2015-02-06 00:28:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902903002/1
5 years, 10 months ago (2015-02-06 00:47:30 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 01:17:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/9fff96b43...

Powered by Google App Engine
This is Rietveld 408576698