Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: build/common.gypi

Issue 902903002: NaCl: Remove use of NACL_BUILD_* in common.gypi. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index a391a6bfe9f588edb1e578798d5be382f45974ec..bc6bf2bf767df99608b8ba171e0063d3a1bbbb43 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -187,12 +187,6 @@
'target_conditions': [
['win_target=="x64"', {
'target_arch': 'x64',
- 'defines!': [
- 'NACL_BUILD_SUBARCH=32',
- ],
- 'defines': [
- 'NACL_BUILD_SUBARCH=64',
- ],
'configurations': {
'Common_Base': {
'msvs_target_platform': 'x64',
@@ -201,31 +195,6 @@
}],
],
'conditions': [
- # TODO(gregoryd): split target and build subarchs
- ['target_arch=="ia32"', {
- 'defines': [
- 'NACL_BUILD_SUBARCH=32',
- 'NACL_BUILD_ARCH=x86',
- ],
- }],
- ['target_arch=="x64"', {
- 'defines': [
- 'NACL_BUILD_SUBARCH=64',
- 'NACL_BUILD_ARCH=x86',
- ],
- }],
- ['target_arch=="arm"', {
- 'defines': [
- 'NACL_BUILD_ARCH=arm',
- 'NACL_BUILD_SUBARCH=32',
- ],
- }],
- ['target_arch=="mipsel"', {
- 'defines': [
- 'NACL_BUILD_ARCH=mips',
- 'NACL_BUILD_SUBARCH=32',
- ],
- }],
['linux2==1', {
'defines': ['LINUX2=1'],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698